search

twingly / ecco

:dolphin: MySQL replication binlog parser in JRuby
7 stars 2 forks source link

Convert rows from Java to Ruby class #57

Closed Chrizpy closed 3 years ago

Chrizpy commented 4 years ago

Related to the issue https://github.com/twingly/ecco/issues/26 Taking a piece from https://github.com/twingly/ecco/pull/56, as mentioned in that PR, the work done there should be broken down in smaller pieces, beginning with this PR.

This PR introduces Rubyconverter which translates that Java object in rows into Ruby objects

Chrizpy commented 4 years ago

Sprint87: Abstrahera bort Java-objekt i rader

walro commented 4 years ago

I also mentioned this somewhere before (IRL?) but I think some kind of "deep inspect spec" on the resulting objects would be good. Just to ensure that we have found all Java traces. Ensure that all different type of "rows" are checked as I think it differs between INSERT/UPDATE/DELETE/YOUNAMEIT

Also (perhaps another PR building on this one), everything is basically mapped 1:1 with the Java implementation. I feel that the Java version is a bit obsessive with using primitive/built-in types rather than introducing better data structures (why we end up with awkward things as lists with "pairs" with lists)

walro commented 3 years ago

I hope I got the merge right in 94a8df6, the specs passed locally at least :)

Chrizpy commented 3 years ago

Heh, sorry for reviving this. :P