search

twingly / twingly-amqp

:bus: Ruby gem for RabbitMQ subscribing and publishing
0 stars 0 forks source link

Make it possible to cancel non-blocking subscribers #101

Closed roback closed 11 months ago

roback commented 11 months ago

Before this it was only possible to cancel blocking subscribers. I just happened to run into this issue when trying to get the tests to work with quorum queues in https://github.com/twingly/twingly-amqp/pull/100#discussion_r1352104924

This may not be the best looking solution, but this was the easiest way to fix it, and I think it's good enough :)

close #86

roback commented 11 months ago

The tests passes locally on Ruby 3.1.2 🙃

Edit: Fixed it in a force-push. The problem was that we need to assign a value to the @blocking variable before setting up the consumer, just so we can use it inside the consumer (which we do in some of the tests).