Add lib/twingly/version.rb

twingly / twingly-search-api-ruby

:gem: Twingly Blog Search API in Ruby

https://developer.twingly.com/

MIT License

4 stars 0 forks source link

Add lib/twingly/version.rb #78

Open dentarg opened 6 years ago

dentarg commented 6 years ago

Doesn't look like we keep this file up to date:

https://github.com/twingly/twingly-search-api-ruby/blob/9939e182cdb249c627ba6d1061311de74edcc9f3/lib/twingly/livefeed/version.rb#L1-L5

I don't think this file has any real purpose.

Let's add lib/twingly/version.rb (see comment below).

Update README when doing this: https://github.com/twingly/twingly-search-api-ruby#release

dentarg commented 6 years ago

Maybe we need to keep lib/twingly/{livefeed,search}/version.rb around, to not break stuff, but they could get the value from lib/twingly/version.rb.

walro commented 6 years ago

Maybe we need to keep lib/twingly/{livefeed,search}/version.rb around, to not break stuff, but they could get the value from lib/twingly/version.rb.

Yeah, sounds smart

jage commented 5 years ago

What should the module name be, for the common version?

Now we have:

Twingly::Search::VERSION
Twingly::LiveFeed::VERSION

I don't think we should add Twingly::VERSION, so we need a new name.

Some ideas:

Twingly::BlogApiClient::VERSION
Twingly::Search::VERSION (I.e. LiveFeed will just use the Search version as the gem is still named search, no new file at all)