search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

Upgrade Guice to 5.0.1+ #559

Open greggdonovan opened 3 years ago

greggdonovan commented 3 years ago

Is your feature request related to a problem? Please describe.

Finatra depends on Guice 4.2.x which depends on cglib which is no longer being developed and has not been updated to the new JDK9+ module system. See this Guice issue for more discussion.

Describe the solution you'd like

Upgrade Guice from 4.2.x to 5.0.1+.

Describe alternatives you've considered With Guice 4.2.x's use of cglib, users need to add --add-opens java.base/java.lang=ALL-UNNAMED or something like it to their JVM startup options.

Additional context N/A

cacoco commented 3 years ago

@greggdonovan Thanks for the issue, please note that Finatra is still only targeted to work with JDK8 at the moment (and soon JDK11).

greggdonovan commented 3 years ago

@cacoco Thanks! FWIW, we've been running Finatra for a year in production with JDK11 with no issues. This issue came up during testing of our JDK16 upgrade.

cacoco commented 3 years ago

@greggdonovan that's great! Thanks again for the issue.

redkhalil commented 2 years ago

Any update on the timeline for next supported version of JDK?

cacoco commented 2 years ago

@redkhalil we're targeting JDK11 support for Q1 or Q2 of 2022.