search

twitter / util

Wonderful reusable code from Twitter
https://twitter.github.io/util
Apache License 2.0
2.69k stars 583 forks source link

Update Scala 2.13.1 to 2.13.6 #289

Closed felixbr closed 3 years ago

felixbr commented 3 years ago

Problem

The latest Scala 2.13.x version is compatible with Scala 3.0.0 and includes many useful compiler-tools (e.g. warnings) to make the transition - and development in general - easier. Even if we don't have a real Scala 3 cross-build, 2.13.6 can be consumed by Scala 3 projects.

Solution

Updating Scala 2.13.1 to 2.13.6

Result

The build uses Scala 2.13.6. I also used the 2.13.x version as default as it has many extremely useful warnings that 2.12.x doesn't have. The only part that needed fixing is some reflection code as 2.13.5 changed encoding of method-parameter names.

As usual, I cannot tell if this clashes with any Twitter-internal things, so please tell me if it does.

mosesn commented 3 years ago

Great! Again, I don't think this will clash with anything, but let me double check.

mosesn commented 3 years ago

Sorry for the delay, this was merged in a couple of days ago but I screwed up and merged in a bug with it too. Thanks again for the patch, and sorry again about the delay.