Closed felixbr closed 2 years ago
Merging #295 (23767e6) into develop (91551dc) will not change coverage. The diff coverage is
80.00%
.
@@ Coverage Diff @@
## develop #295 +/- ##
========================================
Coverage 52.62% 52.62%
========================================
Files 316 316
Lines 16864 16864
Branches 1035 1045 +10
========================================
Hits 8875 8875
Misses 7989 7989
Impacted Files | Coverage Δ | |
---|---|---|
...g/src/main/scala/com/twitter/logging/Handler.scala | 47.05% <0.00%> (ø) |
|
...c/main/scala/com/twitter/logging/FileHandler.scala | 82.97% <100.00%> (ø) |
|
...ng/src/main/scala/com/twitter/logging/Logger.scala | 61.29% <100.00%> (ø) |
|
...in/scala/com/twitter/logging/QueueingHandler.scala | 93.75% <0.00%> (-6.25%) |
:arrow_down: |
util-core/src/main/scala/com/twitter/io/Buf.scala | 93.27% <0.00%> (+0.35%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 91551dc...23767e6. Read the comment docs.
Not sure why com.twitter.app.AppTest
is failing (different module and works locally), might be a flaky test.
I rebased the PR onto develop
, removed the now unnecessary .toLong
conversion, and fixed one more deprecation warning regarding Scala 3.
I think the PR can now be merged, if you like. 🙂
Merged! b8a30a7
This adds Scala3 cross-buliding for the module
util-logging
as discussed in #290