Random fixes

[Demigod21]

replaced substring with dropright for best practice

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: Demigod21
:x: deepsourcebot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[cacoco]

@Demigod21 can we ask that you remove the .deepsource.toml file from this commit? Thanks!

[Demigod21]

I didn't notice it, now I removed it, thank you and have a nice day :)

Il giorno lun 16 mag 2022 alle ore 19:44 Christopher Coco < @.***> ha scritto:

@Demigod21 https://github.com/Demigod21 can we ask that you remove the .deepsource.toml file from this commit? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/twitter/util/pull/299#issuecomment-1127957490, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBNGRSKXUHOY3SAE2FE53LVKKCPNANCNFSM5V64FYHQ . You are receiving this because you were mentioned.Message ID: @.***>

[mosesn]

@Demigod21 sorry for the delay in looking at this! can you tell me more about the motivation behind this patch? the nice thing about the current approach is that it only uses methods are native to String, so we don't need to use the StringOps implicit for dropRight. this makes compilation a tad faster, and can shave some unnecessary work. What do you think makes dropRight more appropriate here?

[mosesn]

Also, would you mind signing the CLA? Thank you!

[Demigod21]

Good morning!

I already signed the CLA. Anyway feel free to discard my PR, I'm a newbie in the Scala world and I'm trying to improve my skills with the documentation and deepsource and I understood that dropRight is more efficient than substring.

But as I said, I'm just a newbie, so thank you for your explanation and have a nice weekend :)

Il giorno mar 31 mag 2022 alle ore 22:04 Moses Nakamura < @.***> ha scritto:

Also, would you mind signing the CLA? Thank you!

— Reply to this email directly, view it on GitHub https://github.com/twitter/util/pull/299#issuecomment-1142589933, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBNGRTJIOI7XHA765KLRCLVMZWDPANCNFSM5V64FYHQ . You are receiving this because you were mentioned.Message ID: @.***>

[mosesn]

@Demigod21 OK! Well, welcome to Scala and Open Source :) We won't accept this PR for now, but we look forward to future PRs from you