search

twogood / unshield

Tool and library to extract CAB files from InstallShield installers
MIT License
351 stars 75 forks source link

fix travis CI builds #116

Closed wdlkmpx closed 3 years ago

wdlkmpx commented 3 years ago

no changes to master branch: https://travis-ci.org/github/twogood/unshield/builds/770284567

enable sudo: https://travis-ci.org/github/twogood/unshield/jobs/770288331

use ubuntu bionic (fixes ALL linux builds): https://travis-ci.org/github/twogood/unshield/builds/770289201 one GCC test fails: ./test/v5/CVE-2015-1386/CVE-2015-1386.sh

ALL the OSX builds compile fine but this test always fails: Running test ../test/v5/CVE-2015-1386/CVE-2015-1386.sh

OSX might do things differently, so CVE-2015-1386.sh should probably be disabled for osx

twogood commented 3 years ago

OSX does not have GNU realpath something..

wdlkmpx commented 3 years ago

Oh, so it takes some time to analyze the builds, the only linux Travis Job that fails to compile: USE_OUR_OWN_MD5=1 BUILD_STATIC=0 

/usr/bin/ld: md5/libmd5.a(md5c.c.o): relocation R_X86_64_PC32 against symbol `MD5Update' can not be used when making a shared object; recompile with -fPIC

Once the code is compiled into a binary, all the linux tests pass.

This is not a problem in the md5 PR https://travis-ci.org/github/twogood/unshield/builds/770294268

I'll proceed to create proper commits for merging this PR to fix the travis jobssss