finish transition from autotools to CMake

twogood / unshield

Tool and library to extract CAB files from InstallShield installers

MIT License

351 stars 75 forks source link

finish transition from autotools to CMake #119

Closed wdlkmpx closed 3 years ago

wdlkmpx commented 3 years ago

fix: unshield_config.h.in

everything was defined to 1 whether the header files were detected or not
lib/internal.h: detect __BIG_ENDIAN__ with pendian_detect.h

WORDS_BIGENDIAN is defined if autotools macro AC_C_BIGENDIAN detects a big endian system

autotools stuff was removed years ago and let's not rely on CMake for this either

pendian_detect.h just "Uses various known flags to decide endianness and defines"

wdlkmpx commented 3 years ago

This PR makes the appveyor build produce less warnings, more readable build log, it still fails to find zlib https://ci.appveyor.com/project/twogood/unshield/builds/39119716

wdlkmpx commented 3 years ago

I added a commit that changes ${ZLIB_LIBRARIES} to ZLIB::ZLIB to see if the appveyor build succeeds, it doesn't, so I removed that commit.

-- Found ZLIB: C:/Users/appveyor/scoop/apps/zlib-dev/current/lib/libz.dll.a (found version "1.2.3") -- Found OpenSSL: C:/OpenSSL-Win64/lib/libeay32.lib (found version "1.0.2u")

zlib is a dll.a file, openssl is a .lib file, I wonder it that is the reason