search

twolfson / spritesmith

Utility that takes sprites and converts them into a stylesheet and its coordinates
MIT License
911 stars 56 forks source link

Generated sprites have lots of empty space at bottom right corner #48

Closed minevala closed 9 years ago

minevala commented 9 years ago

I'm using gulp.spritesmith to generate sprites. I've noticed recently a large empty area at right bottom corner of the sprites. Root cause might be: "layout": "~2.0.0" --> "layout": "~2.1.0". I'm using mac OSX 10.10.1

twolfson commented 9 years ago

Yep, we switched our binary packing algorithm but everything should have more/less remained the same. Can you provide us with a copy of the sprites or the dimensions of said images?

minevala commented 9 years ago

Here is link to sprite: https://github.com/minevala/icons/blob/master/sprite.png I'm using options:

twolfson commented 9 years ago

That's the generated spritesheet. We need the sprites themselves to reproduce. Otherwise, it is a very tedious manual process.

minevala commented 9 years ago

There are the files and the sprite https://github.com/minevala/icons

twolfson commented 9 years ago

Awesome, thanks! I will take a look at this by the end of the weekend.

twolfson commented 9 years ago

A fix has been merged and released in spritesmith@1.2.0, grunt-spritesmith@3.9.0, and gulp.spritesmith@2.8.0. Thanks for the bug report!

minevala commented 9 years ago

Nice :+1: