search

txaty / go-merkletree

Go Merkle Tree. High performance, Supporting parallel run, OpenZeppelin sorting pairs.
https://pkg.go.dev/github.com/txaty/go-merkletree
MIT License
110 stars 17 forks source link

feat: add OpenZeppelin sort-pair verification support #20

Closed dev-ubq closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #20 (45a1491) into main (6ccb37a) will decrease coverage by 0.56%. The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   92.12%   91.56%   -0.57%     
==========================================
  Files           2        2              
  Lines         457      474      +17     
==========================================
+ Hits          421      434      +13     
- Misses         24       27       +3     
- Partials       12       13       +1
Impacted Files Coverage Δ
merkle_tree.go 91.41% <86.20%> (-0.57%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

txaty commented 1 year ago

Thank you so much for your PR. I think it is an outstanding feature, and I would like to merge it into the main branch. But please allow me more time to review and refactor the code for performance and readability concerns.

txaty commented 1 year ago

As I do not have the access to modify this PR, I have created another PR: https://github.com/txaty/go-merkletree/pull/21 based on this. Please check it. Thank you. This PR can be closed now.