txaty / go-merkletree

Go Merkle Tree. High performance, Supporting parallel run, OpenZeppelin sorting pairs.
https://pkg.go.dev/github.com/txaty/go-merkletree
MIT License
110 stars 17 forks source link

Refactor #30

Closed txaty closed 8 months ago

txaty commented 8 months ago
  1. Removed goroutine pool (gool). Using goroutine pool causes overhead and increases the complexity of the code base.
  2. Changed the proof generation method. Now proofGen parallelized algorithm doesn't require two buffers.
  3. Added fuzzing test.
  4. More unit tests were added to achieve 100% coverage.
  5. Refactored many methods and functions.
  6. Extracted methods and functions to separate files to increase readability.
github-actions[bot] commented 8 months ago

Fuzz test failed on 8fedf34addfb70a66bb9f871981878a4bdd16bbb. Using the GitHub CLI, download the seed corpus with

gh run download 6966564263 -n testdata
github-actions[bot] commented 8 months ago

Fuzz test failed on aa3e3ee29bed26da11514d808c17cdb966affbb4. Using the GitHub CLI, download the seed corpus with

gh run download 6966575639 -n testdata
github-actions[bot] commented 8 months ago

Fuzz test failed on 3ab265a887f5b0998d99978641e3a519596c13c1. Using the GitHub CLI, download the seed corpus with

gh run download 6966632389 -n testdata
github-actions[bot] commented 8 months ago

Fuzz test failed on c486d903577e8fa5218d331e5f679aa437d0ca46. Using the GitHub CLI, download the seed corpus with

gh run download 6966717712 -n testdata
github-actions[bot] commented 8 months ago

Fuzz test failed on 98cd7b1082a350997218fce6cf7c60d1c69849f2. Using the GitHub CLI, download the seed corpus with

gh run download 6966738295 -n testdata
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e399a58) 98.02% compared to head (155e37b) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## =========================================== + Coverage 98.02% 100.00% +1.97% =========================================== Files 2 8 +6 Lines 455 441 -14 =========================================== - Hits 446 441 -5 + Misses 6 0 -6 + Partials 3 0 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.