search

txdv / LibuvSharp

.NET bindings for libuv
176 stars 41 forks source link

UVStream: Added uv_write for multiple buffers #14

Closed dcodeIO closed 8 years ago

dcodeIO commented 8 years ago

Saves a couple of native calls and potentially a few syscalls where applicable (i.e. HTTP proxies).

txdv commented 8 years ago

I really have to get around doing that appveyor integration test.

Looks nice, you even adhered to the surrounding code style, although you used spaces instead of tabs for block indentation, would you mind fixing that?

Would you be willing to write a test case to test if the sending with this primitive works?

dcodeIO commented 8 years ago

Regarding a test case: I am using the net35 solution here. Seems I need Xunit for the default one containing the tests, which I am not yet familiar with. If not absolutely necessary, I'd rather postpone that.

txdv commented 8 years ago

Are you using this for unity?

dcodeIO commented 8 years ago

Yes, I am. Why do you ask?

txdv commented 8 years ago

Just curiosity. I talked to someone else too, this is why re-created the 3.5 target.

Are you actually using it already or just toying with it?

dcodeIO commented 8 years ago

I am currently replacing websocket-sharp with a new http/websocket library based on your library. I don't have it out in the wild, yet, but I already spent a good amount of time porting and did quite a few load tests. Works well within Unity so far on x86/64 Windows and Linux.