search

tyabus / xash3d

Bugfixed & Improved Xash3D
https://dsc.gg/tyabus
GNU General Public License v3.0
36 stars 13 forks source link

Lots of server message indices are wrong #15

Open Velaron opened 2 years ago

Velaron commented 2 years ago

This is usually not a problem, but for example when using amxmodx with gungame, it tries to send a "svc_finale" message with index 31, while in xash3d index 31 is "svc_modelindex" causing a crash.

Mr0maks commented 2 years ago

This is an incompatibility between the protocols of the old xash and goldsrc.

Unfortunately, this cannot be fixed without breaking compatibility with old clients. But you can use SVC_INTERMISSION instead of SVC_FINALE. If you need to add text in the center, then you have to add a couple of lines of code.

a1batross commented 2 years ago

There is an idea:

https://github.com/tyabus/xash3d/blob/master/engine/server/sv_game.c#L2526

In this function, it can be possible to dynamically rewrite svc_finale to something that will emulate its behavior, use both of svc_intermission and TE_TEXTMESSAGE for example. Intermission level won't be correct, but at least it would work.