tycho-kirchner / fastcompmgr

A fast compositor for X11
Other
75 stars 3 forks source link

Implement fade functionality and fix Makefile uninstall target #10

Closed MalcolmReed-ent closed 1 month ago

MalcolmReed-ent commented 1 month ago

This update introduces fade functionality to fastcompmgr and corrects issues with the Makefile:

Fade Functionality:

Makefile Changes:

Edit: Also if there is anything i could possibly add, change, or improve on, give me a call, im open to improving and stretching the capabilities this comp

tycho-kirchner commented 1 month ago

Hello @MalcolmReed-ent

  • Implemented fade-in effect for newly mapped windows
  • Implemented fade-out effect for unmapping windows
  • Adjusted fade timing and opacity calculations in the run_fades function

So, this is the internet and thus it's hard to guess your intentions here, but are you serious? You did not implement anything, but instead re-enabled a single line of source code that I commented out for a reason. Properly re-implementing fading requires a lot more work. If you browse through my modifications to the original xcompmgr you might notice that I changed core-functionalities, for instance how windows are mapped after ConfigureNotify events (3b3a405bb79aee3a3cbb8b4566213f7eb10997ca). While on a first glance fading might appear to be working, switching virtual desktops in openbox quickly produces artifacts in form of black bars around windows. And I'm sure that's just the tip of the iceberg. So, I'm sorry, but it's not so simple here.

241006_224947