tye-v2 / tye2

Tye2 is a local orchestrator tool that makes developing and testing microservices and distributed applications easier.
https://www.tye2.org
MIT License
1 stars 2 forks source link

Fix skipped unit tests on linux github action workflow #23

Open razvangoga opened 4 months ago

razvangoga commented 4 months ago

1. on linux agent when tye2 was still on dotnet 6

// tests tagged with
[Trait("FailsInGithubActions", "true")]

Originally posted by @razvangoga in https://github.com/tye-v2/tye2/issues/7#issuecomment-1967567401

2. on linux agent after upgrading tye2 was to dotnet 8

// tests tagged with
[Trait("FailsAfterNet8", "true")]

disabled to get #30 merged

drakon660 commented 3 months ago

I will check those 2 failing tests

razvangoga commented 3 months ago

All tests (old and new ones) pass when i run the entire unit tests suite locally (win 11 with latest docker desktop version running in wsl2). They crash only in the ga workflow.

My ideea here was to spinn up an ubuntu vm and try to run the tests in it so they are as close as posible to the workflow’s setup…

On Thu, Mar 7, 2024 at 19:22 drakon660 @.***> wrote:

I will check those 2 failing tests

— Reply to this email directly, view it on GitHub https://github.com/tye-v2/tye2/issues/23#issuecomment-1984164917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIETZQFW54BCB75MIE6G7LYXCV47AVCNFSM6AAAAABD43ZIQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGE3DIOJRG4 . You are receiving this because you authored the thread.Message ID: @.***>

drakon660 commented 3 months ago

Ok I will check on mac os also.