search

tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Resume store structure #1159

Closed tarex closed 8 years ago

tarex commented 8 years ago

Closes #855

nelonoel commented 8 years ago

Also, @tarex I thought the #855 intended to put async calls on Reflux's preEmit hook?

nelonoel commented 8 years ago

Reordering doesn't work correctly.

tarex commented 8 years ago

i haven't found any error in the frontend of the resume order , checked on live site , there we're having same problem , so it might be related to backend . @UnspeakableHorror

UnspeakableHorror commented 8 years ago

Ok, I'll check.

tarex commented 8 years ago

oh , for the Objective section its not working , rest of the things are ok .

UnspeakableHorror commented 8 years ago

Yeah, I think I created an issue to remove the handles for that. I'll try to find it.

UnspeakableHorror commented 8 years ago

Found it https://github.com/natebenson/vyllage/issues/1109.

nelonoel commented 8 years ago

@tarex this is mergeable for the purpose of the resumé store structure change. However, please note that this doesn't fully close #1109 yet as you have to disable reordering for the Objective section on the front-end side as well to avoid confusion.

I was thinking of not showing the "Move" handle and adding a light gray border on the Objective section when reordering.

tarex commented 8 years ago

No it doesn't resolve #1109 , only #855