tylerbenson / vyllage

https://www.vyllage.com
4 stars 0 forks source link

Account settings refactor #1178

Closed UnspeakableHorror closed 8 years ago

UnspeakableHorror commented 8 years ago

Closes https://github.com/natebenson/vyllage/issues/803. Closes https://github.com/natebenson/vyllage/issues/943.

In the end I only moved some things a bit and added a bunch of tests, I'm not sure if it's even worth trying to simplify things more.

UnspeakableHorror commented 8 years ago

So I did not do any change on the html files but the CIs are failing with

21:45:08] Beautifying adminBatchAccountCreation.html

events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: src/base.scss
Error: It's not clear which file to import for '@import "normalize-scss/normalize"'.
       Candidates:
         normalize-scss/_normalize.scss
         normalize-scss/normalize.css
       Please delete or rename all but one of these files.
        on line 3 of stdin
>> @import "normalize-scss/normalize";
   ^

    at options.error (/mnt/home/u7597/src/repo/vyllage/assets/node_modules/gulp-sass/node_modules/node-sass/lib/index.js:277:32)

npm ERR! Linux 3.2.0-92-virtual
npm ERR! argv "/usr/local/node/0.12.7/bin/node" "/usr/local/node/0.12.7/bin/npm" "run" "build"

Same with CircleCI.

UnspeakableHorror commented 8 years ago

@tarex, @nelonoel , any ideas?

tylerbenson commented 8 years ago

It would be nice if this was more digestible into smaller PRs. Try to break it up in the future.

UnspeakableHorror commented 8 years ago

Ok.