search

tylercamp / palcalc

MIT License
33 stars 5 forks source link

Fix tooltip line breaks. #41

Closed Fusionette closed 4 months ago

Fusionette commented 4 months ago

The localization export didn't properly recognize 
 as a line break.

tylercamp commented 4 months ago

Does this work as expected in UI? is a special code for line breaks in elements which don't generally respond to \n (e.g. tooltips)

tylercamp commented 4 months ago

Ah yep, was responding on my phone from the car while getting coffee, the old char code was specifically for newlines in XAML attributes and not something special for certain elements (was comparing it to  ), ty for catching that

tylercamp commented 4 months ago

Also @Fusionette I noticed your branch for displaying IVs, I pushed some WIP docs for translations https://github.com/tylercamp/palcalc/tree/main/PalCalc.UI/Localization

Fusionette commented 4 months ago

Also @Fusionette I noticed your branch for displaying IVs

I'm not planning to submit that branch as a PR because it just assumes the best case scenario where children get the best IVs from each parent, which is not realistic. It's fine in order to see what is the potential best result if you're willing to try hundreds of times, but it would be misleading to show it by default.

tylercamp commented 4 months ago

It could be useful to add as a "potential IVs" indicator, but I agree that in general it could be confusing for expectations about breeding time estimates