search

tylergaw / day-player

A Sketch Plugin for creating placeholder images from online services.
MIT License
391 stars 22 forks source link

No services are working in Sketch Beta 3.2 #14

Closed tylergaw closed 9 years ago

tylergaw commented 10 years ago

This doesn't appear to be an issue with any particular service, seems more broad.

Haven't dug into it yet. Only thing I'm seeing in console right now is:

Exception: {
    column = 67;
    line = 74;
    sourceURL = "/Users/tyler/Library/Containers/com.bohemiancoding.sketch3.beta/Data/Library/Application Support/com.bohemiancoding.sketch3/Plugins/day-player/Unsplash.it.sketchplugin";
}

Will investigate further.

davidklaw commented 9 years ago

Pretty certain this has to do with the imageCollection.addImage_name_convertColourspace() call. I'm writing a plugin for 3.2 that's bombing out on the same call.

tylergaw commented 9 years ago

Ah cool, thanks for the heads up @davidklaw

davidklaw commented 9 years ago

Sure thing. This syntax worked for me.

[imageCollection addImage:img convertColourspace:false]

haydenbleasel commented 9 years ago

Hey @tylergaw any ETA on this? I use this plugin on the daily :) Nice work btw.

tylergaw commented 9 years ago

@haydenbleasel I think I can get it in tonight (EST). Shouldn't be too bad (famous last words).

davidklaw commented 9 years ago

@tylergaw We believe in you! :godmode:

davidklaw commented 9 years ago

:100: points

tylergaw commented 9 years ago

@davidklaw Thanks for pointing me to that method change. I asked a question about it on the mailing list http://mail.sketchplugins.com/pipermail/dev_sketchplugins.com/2015-January/001094.html to see if we could get some more clarity.

tylergaw commented 9 years ago

This is out in master and in a new release https://github.com/tylergaw/day-player/releases/tag/v1.1.0. Gonna close this now. Thanks folks. cc: @haydenbleasel