search

tylernguyen / x1c6-hackintosh

READMEs, OpenCore configurations, patches, and notes for the Thinkpad X1 Carbon 6th Gen 2018 Hackintosh
https://tylernguyen.github.io/x1c6-hackintosh/
The Unlicense
637 stars 109 forks source link

YogaSMC #87

Closed tylernguyen closed 3 years ago

tylernguyen commented 4 years ago

YogaSMC is progressing quickly thanks to the great @zhen-zen

This issue thread will serve as a placeholder for the project: its features, bug, and application as it relates to the x1c6 machine.

The repo is already setup for YogaSMC with SSDT-EC and the kext. All you need to do is to install the app and preference panel to make adjustments.

Currently, I have confirmed the following working:

Not-working

Additionally, YogaSMC is built automatically with each commit, so update as you test 👍

Feel free to chime in.

EDIT: As of v1.30, Fan control now works

benbender commented 4 years ago

Some remarks:

EigenTom commented 4 years ago

I‘ve tested YogaSMC several weeks ago, with version 1.2.1 Release. The fan cannot be controlled, but you can see readings of fan speed inside of the panel. However, the digit seems to be static. Perhaps @zhen-zen haven't implemented fan-speed automatic refreshing.

Looking forward to full support of fan control&reading. The X1 Carbon will perform way better with its fan ON when doing extensive works or running benchmarks. Currently with tyler's CPUFriendDataProvider with my own tuning (with undervolt and hw heatsink modding, unlocked PL1 and PL2, with no manually fan control), the machine can run up to 880/3700 on Geekbench 5, macOS. The X1 Yoga 3rd with the same spec under Windows 10 with the CPU locked to the highest freq using throttlestop and set fanspeed to maximum using tpfancontrol, can run up to 1050/4100 on Geekbench 5. Considering the larger size and the better design of the heatsink, I think x1c has greater potentials for us to explore.

buyddy commented 4 years ago

It seems that I have no reading of the charge threshold and fan speed. Is there anything I am missing? Other functions seems to be fine.

Also from wakeup, LED of Mute is on. The volume status is reversed, and there is no sound. Use Volume up and down will fix the issue. Seems like a bug with YogaSMC.

Also I realize now in IntelPowerGadget my min frequency won't go below 0.9GHz anymore. The same CPUDataProivder let me go down to 0.6Ghz/0.5Ghz. I am wondering if I need to regenerate it?

buyddy commented 4 years ago
Screen Shot 2020-11-05 at 2 07 32 PM

@tylernguyen Do you have the same issue?

tylernguyen commented 4 years ago
Screen Shot 2020-11-05 at 2 07 32 PM

@tylernguyen Do you have the same issue?

buyddy commented 4 years ago

@tylernguyen are you able to enter numbers? I can't seem to enter anything. Also do you have the issue of wake up from sleep and the Mute Botton is on (and there is no sound)?

tylernguyen commented 4 years ago

@tylernguyen are you able to enter numbers? I can't seem to enter anything.

Also do you have the issue of wake up from sleep and the Mute Botton is on (and there is no sound)?

I'm on the latest commit build from the actions tab. Are you guys on the release version?

zhen-zen commented 4 years ago

Actually fan control is available for debug binaries... And the fan speed display on prefpane will be removed in the future.

buyddy commented 4 years ago

@tylernguyen are you able to enter numbers? I can't seem to enter anything. Also do you have the issue of wake up from sleep and the Mute Botton is on (and there is no sound)?

  • My charge threshold works normally.
  • I have not observed that issue.

I'm on the latest commit build from the actions tab. Are you guys on the release version?

I see. This could be the problem. I am on the released version.

buyddy commented 4 years ago

@tylernguyen I still have the issue of waking up and Mute Botton is on with LED on. The sound is not working until I adjust the volume using the Volume UP and Down. This was not the case in the past. Do you have this issue?

tylernguyen commented 4 years ago

@buyddy

Try turning off Mute in LED automation.

buyddy commented 4 years ago

@buyddy

Try turning off Mute in LED automation.

That seems to be the issue. What is the use of that LED automation?

benbender commented 4 years ago

@buyddy Its intended use is to persist the state of the corresponding function to be retained after sleep. So if you've muted your mic before sleeping the notebook it is also muted afterwards. But you are right, see the same issue. Pls open a bug at the repo of YogaSMC so it can be tracked and solved there.

benbender commented 4 years ago

@KirisameMarisaa the patches are here: https://github.com/tylernguyen/x1c6-hackintosh/blob/master/patches/SSDT-EC.dsl and are unrelated to sleep.

tylernguyen commented 4 years ago

@KirisameMarisaa

Just as @benbender stated, YogaSMC dependecies are already implemented by default in the repo (You do not need to anything else other than installing the app and the pref panel). YogaSMC is also unrelated to sleep.

In addition, your sleep seems normal. I believe PWRB is you pressing the power button to wake the machine up. It seems to sleep fine in between the time of entering sleep and you pressing the power button, I presume?

tylernguyen commented 4 years ago

@KirisameMarisaa

RTC wakes are normal, even in real Macs, see https://osxdaily.com/2010/07/17/why-mac-wakes-from-sleep/

You can also try the changes detailed in https://github.com/tylernguyen/x1c6-hackintosh/blob/master/docs/3_README-other.md

As I have stated before, your sleep looks to be functioning fine. As you can you see, it wakes periodically for macOS related tasks. If you have another reasons to believe otherwise, please create a separate issue and refrain from going off topic within this one.

tylernguyen commented 4 years ago

@KirisameMarisaa Just as @benbender stated, YogaSMC dependecies are already implemented by default in the repo (You do not need to anything else other than installing the app and the pref panel). YogaSMC is also unrelated to sleep. In addition, your sleep seems normal. I believe PWRB is you pressing the power button to wake the machine up. It seems to sleep fine in between the time of entering sleep and you pressing the power button, I presume?

No, it doesn't. as shown in the screenshot, abnormal wake reason 'RTC/UserActivity' kept on waking the machine. I've moved on the latest EFI patch you uploaded now, and are doing further testing.

UPDATE: I noticed that with your latest EFI, CPU Package Power cannot go less than 1.7w. Is it related to the TB3 patch? I also noticed that the USB-C ports cannot identify USB-3/3.1 devices. Do I need to flash TB3 chip with the custom firmware in order to get proper power management?

Again, please refrain from going off-topic within this issue.

As detailed within README.md, USB 3.1 hotplug is still work-in-progress. Also as detailed in 1_README-HardwareandBIOS, currently, cpu storms when BIOS assisst is not enabled, you have to choose between tb3 hotplug and power for now.

EigenTom commented 4 years ago

@KirisameMarisaa Just as @benbender stated, YogaSMC dependecies are already implemented by default in the repo (You do not need to anything else other than installing the app and the pref panel). YogaSMC is also unrelated to sleep. In addition, your sleep seems normal. I believe PWRB is you pressing the power button to wake the machine up. It seems to sleep fine in between the time of entering sleep and you pressing the power button, I presume?

No, it doesn't. as shown in the screenshot, abnormal wake reason 'RTC/UserActivity' kept on waking the machine. I've moved on the latest EFI patch you uploaded now, and are doing further testing.

UPDATE: I noticed that with your latest EFI, CPU Package Power cannot go less than 1.7w. Is it related to the TB3 patch? I also noticed that the USB-C ports cannot identify USB-3/3.1 devices. Do I need to flash TB3 chip with the custom firmware in order to get proper power management?

Again, please refrain from going off-topic within this issue.

As detailed within README.md, USB 3.1 hotplug is still work-in-progress Also as detailed in 1_README-HardwareandBIOS, currently, cpu storms when BIOS assisst is not enabled, you have to choose between tb3 hotplug and power for now.

ok, I've deleted all off-topic replies.

tylernguyen commented 3 years ago

As of YogaSMC 1.4.1

I consider YogaSMC implementation within this repo stable. Any issues you have with the repo's implementation should be a separate issue while bugs with the project itself should be opened on the project's repo.