search

typelevel / algebra

Experimental project to lay out basic algebra type classes
https://typelevel.org/algebra/
Other
378 stars 69 forks source link

typo: Rig -> Ring #155

Closed dckc closed 7 years ago

non commented 7 years ago

This isn't a typo. If you look you'll see CommutativeRing below. We have support for both rigs and rings.

johnynek commented 7 years ago

so good! I love this PR. I hope we keep getting it!

(also, Rng fixes welcome).

dckc commented 7 years ago

Oh. Learn something new every day. Wikipedia says "The term rig is also used occasionally ..." under Semiring. Any particular reason not to use "semiring"?

dckc commented 7 years ago

Ah. semiring has 1.

tixxit commented 7 years ago

Yeah - we use Semiring to mean a Ring without an inverse or a multiplicative identity. I think that Semiring is often used for both these cases, with the context in which it's used disambiguating it. However, we need both so we disambiguate them all with Semiring (no multiplicative identity, no inverse), Rig (no inverse), Rng (no multiplicative identity), and Ring :)