typesafe / mnailgun

A simple .Net wrapper library for the Mailgun API that allows you to send messages, create web hooks, manage mailboxes, etc. with minimal effort.
Other
35 stars 25 forks source link

JSON.NET dependency minimum version #26

Open anavarro9731 opened 7 years ago

anavarro9731 commented 7 years ago

Do you have any object to specifying a minimum version in the nuspec file? At present, because there is no version, nuget uses the lowest version rather than the latest, since version 2.8. I think this might be causing various warnings (see below) from problems with version conflicts in any library that uses a newer version at least in .net core/vs17. I am trying to confirm if it is for certain the problem, , but do you see any obvious objections to adding a version="x.x.x" attribute to the reference?

Severity Code Description Project File Line Suppression State Warning MSB3277 Found conflicts between different versions of the same dependent assembly that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed. Bulldog.Infrastructure.HandlerServices C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets 1909