search

typesafehub / sbt-lagom-bundle

Other
0 stars 5 forks source link

Add ACL paths for proxying #10

Closed markusjura closed 8 years ago

markusjura commented 8 years ago

This PR continues the work in PR https://github.com/typesafehub/sbt-lagom-bundle/pull/9. In particular it rebased the PR and made the this method a bit more readable: https://github.com/huntc/sbt-lagom-bundle/blob/f66c5f570331af6db9f3aa8955119fbeff9a503e/src/main/scala/com/typesafe/sbt/bundle/LagomBundle.scala#L193

Original description

Given our service URIs, we must also expose the ACL paths so that the services may be reached from the outside world. The ACL paths must have their paths preserved.

The main shortcoming of this approach compared with our forthcoming ACL implementation of ConductR 1.2 is that we do not test the HTTP method.

Sample output for the chirper-impl:

> show bundleOverrideEndpoints

[info] Some(Map(chirpservice -> Endpoint(http,0,Some(Set(http://:9000/chirpservice, 
http://:9000/api/chirps/live?preservePath, http://:9000/api/chirps/history?preservePath)),None,None), 
akka-remote -> Endpoint(tcp,0,Some(Set()),None,None)))