search

typesafehub / sbt-lagom-bundle

Other
0 stars 5 forks source link

Add ACL paths for proxying #9

Closed huntc closed 8 years ago

huntc commented 8 years ago

Given our service URIs, we must also expose the ACL paths so that the services may be reached from the outside world. The ACL paths must have their paths preserved.

The main shortcoming of this approach compared with our forthcoming ACL implementation of ConductR 1.2 is that we do not test the HTTP method.

Sample output for the chirper-impl:

> show bundleOverrideEndpoints

[info] Some(Map(chirpservice -> Endpoint(http,0,Some(Set(http://:9000/chirpservice, 
http://:9000/api/chirps/live?preservePath, http://:9000/api/chirps/history?preservePath)),None,None), 
akka-remote -> Endpoint(tcp,0,Some(Set()),None,None)))
markusjura commented 8 years ago

LGTM. Added one comment to make the code more readable. This improvement can be also done in a separate PR.

markusjura commented 8 years ago

Created the PR https://github.com/typesafehub/sbt-lagom-bundle/pull/10 to make changes to the current state. In particular it was necessary to rebasse the PR so that the travis tests succeed. I've also modified the this method to make it a bit more readable.

I'll close this PR and continue the work in PR https://github.com/typesafehub/sbt-lagom-bundle/pull/10.

huntc commented 8 years ago

FYI you could have committed/rebased against this one. I gave you the privs. :-)

markusjura commented 8 years ago

I've tried put I wasn't able to push my changes to your repo and branch.