search

typesense / typesense-java

Java client for Typesense
https://typesense.org/docs/latest/api/
Apache License 2.0
58 stars 28 forks source link

Provide separate configuration to set readTimeout on OkHttp #39

Closed natalie-zamani closed 1 year ago

natalie-zamani commented 1 year ago

Description

Right now, the client configuration only exposes a single timeout config, connectionTimeout. That is then used for both the connection and read timeout configs on the underlying OkHttp client: https://github.com/typesense/typesense-java/blob/master/src/main/java/org/typesense/api/ApiCall.java#L52-L53

There should be separate configs for these two values, so that we can more granularly control the behavior of the API client.

Steps to reproduce

Not applicable.

Expected Behavior

The expectation would be to have two separate configuration values for the connection and read timeouts.

Actual Behavior

kishorenc commented 1 year ago

Fixed in v0.3.0