TODO tracking issue - Githubissues

typeshed-internal / stub_uploader

Scripts and actions to auto-upload typeshed stubs to PyPI

Apache License 2.0

21 stars 16 forks source link

TODO tracking issue #65

Open hauntsaninja opened 1 year ago

hauntsaninja commented 1 year ago

From recent PRs, we've accumulated some TODOs in the source code. Putting them in this issue so they're more visible:

Use requires_dist for the version spec we want: https://github.com/typeshed-internal/stub_uploader/blob/32dca63e0cdb13393454bde4ed76fefa72d99a4f/stub_uploader/metadata.py#L198
Have some sensible restrictions on which typeshed distributions can depend on other typeshed distributions. This will let us loosen the external allowlist: https://github.com/typeshed-internal/stub_uploader/blob/32dca63e0cdb13393454bde4ed76fefa72d99a4f/stub_uploader/metadata.py#L151
Less hacky support for distributions that aren't on PyPI: https://github.com/typeshed-internal/stub_uploader/blob/32dca63e0cdb13393454bde4ed76fefa72d99a4f/stub_uploader/metadata.py#L29
Maybe have better support for packages that don't have wheels (add some hacky setup.py parsing): https://github.com/typeshed-internal/stub_uploader/blob/32dca63e0cdb13393454bde4ed76fefa72d99a4f/stub_uploader/metadata.py#L195

Avasam commented 1 year ago

Maybe have better support for packages that don't have wheels (add some hacky setup.py parsing)

Could you look at *.egg-info/requires.txt ? It may not cover all cases. But the problematic ones right now (pycocotools and click-default-group) would work. Feels less hacky, simpler, and doesn't require executing code. Just need to download and unzip the package.

Also possibly useful feature requests: https://github.com/pypi/warehouse/issues/474 https://github.com/pypi/warehouse/issues/8254