search

typst / hayagriva

Rusty bibliography management.
Apache License 2.0
350 stars 55 forks source link

Add note field to interop #218

Closed Drodt closed 1 month ago

Drodt commented 1 month ago

The note field of biblatex was not added to the note field of hayagriva during conversion. This PR fixes this.

EpicEricEE commented 1 month ago

Should this maybe rather replace the annotation in the block above? The annotation is later used for the annote field after all so it doesn't really make sense to have it twice.

Drodt commented 1 month ago

Should this maybe rather replace the annotation in the block above? The annotation is later used for the annote field after all so it doesn't really make sense to have it twice.

Looks like you're right. But I would like confirmation by the main developers. I don't want to break things.

reknih commented 1 month ago

I'll check tomorrow. I have a hunch that our documentation of annote and note switches their meaning up vis-à-vis biblatex and possibly CSL.

By the way @Drodt, do you think you can update #105? I like the change and we will release a new Hayagriva version tomorrow.

Drodt commented 1 month ago

By the way @Drodt, do you think you can update #105? I like the change and we will release a new Hayagriva version tomorrow.

It can be merged without errors now.

reknih commented 1 month ago

Closed in favor of #220