search

ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.
https://ualibraries.github.io/Guide-on-the-Side/about.html
Other
66 stars 48 forks source link

PHP Notice: Use of undefined constant username - assumed 'username' in CasAuthenticate.php on line 59 #177

Closed pbhenson closed 6 years ago

pbhenson commented 6 years ago

Looks like there's a missing $ in the code in question:

public function getUser($request = null) {
    $username = $this->determineUsername();
    if (username) {
        return $this->_findUser($username);
    } else {
        return false;
    }
}
michaelhagedon commented 6 years ago

Thanks, @pbhenson! I don't have CAS set up to test this right now, but that's a obvious error. This is fixed in master; let us know if you find it doesn't work.