Adding an option to disable pop-ups

matsushita1918 commented 1 year ago

Preliminary checklist

[X] I have read the README
[X] I have read the FAQs.
[X] I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.
[X] I have searched wont fix issues and this request is not among them
[X] This is a feature request for the Cromite browser; not the website nor F-Droid nor anything else.

Is your feature request related to privacy?

Yes

Is there a patch available for this feature somewhere?

No

Describe the solution you would like

A way for a user to manually set the number of tabs that would be allowed to open like the extension tablimiter or xtab in the chrome webstore and a way to really prevent redirects, I asked the same thing here https://stackoverflow.com/questions/77554567/a-way-to-actually-block-redirects-and-popups-and-to-limit-number-of-tabs-in-andr here is my question there. If you guys could implement this it would be totally legendary!

A way to actually block redirects and popups and actually limit the number of tabs in Android chromium based browsers, the block pop-ups and redirect option is useless in a browsers settings, doesn't do anything at all to prevent this, since you can't install extensions in Android based browsers, there seems to be absolutely no way to prevent new tabs from opening when you click on links on sites, except for disabling Java script which breaks web pages, or quickly closing out of the tab that suddenly opens, this is even on a brand-new device, so there is absolutely no malware on it, I'm even using https://github.com/uazo/cromite which seems to be the best security oriented browser for Android atm, this browser integrates ad block plus only other thing I could think of is a custom filter list to prevent this, but im at a loss, it seems like a huge security risk, eventually one of these popup tabs will drop a payload.

Describe alternatives you have considered

Every browser available on Android, every AdBlock program, every setting in a browser, every way you can word this question into google

Universalizer commented 1 year ago

Especially cosmetic.user.js filering for pop up blocking and idcac.user.js (I don't care about cookies), Probably, also for some redirects related to CNAME Trackers (Whether original or disguised)

https://github.com/uazo/cromite/issues/347#issuecomment-1779816442

uazo commented 1 year ago

block redirects and popups and actually limit the number of tabs in Android chromium based browsers

seem to me two different requests. While I can perhaps understand the meaning of the first, I do not understand your second request: it is not my aim to restrict the use of the browser for users. so, if you agree, I would only talk about the first one.

In order to evaluate your request, I would need links of examples of what happens and what you would like to achieve. such as this one https://code.ptcong.com/better-js-popunder-script/, which is, however, blocked.

matsushita1918 commented 1 year ago

For a good example this site would show you the popup stuff im talking about when you try to click links, new tabs open without me wanting them to, you either have to quickly close them before they have the chance to load, or they sit open in the background until you manually close them. I try to close them before they load before they may potentially have enough time to drop something on my system without knowing. https://9anime.se/ there are many other free streaming sites that have this, it would be cool to have the option for the user to set a number of tabs that are allowed to open, say if I set it to one tab or even 3 tabs whatever number we'd chose, only one tab will be allowed to run or whatever number I punch in, as I said similar to xtab or tab limiter on a desktop oses browser, if another tries to spring up to some random page, it'll automatically close, it would be amazing to have a toggle switch in the settings to either enable or disable this feature and would be great and increase security to prevent pages from opening new tabs or new instances of chrome. As far as the redirects go, it would be nice to be able to load pages without them loading another link on the main page your visiting, the popups and redirects switch in the settings don't really do much in the way of preventing redirects. It isn't that you'd have to force this option on all the time to limit your users, but have the option available to people who would want to increase security. I'm not a coder myself, so I wouldn't know how to do this on android, but I'll say this, I really do appreciate all the work you have done here, it is certainly a huge undertaking. I also really appreciate you hearing my request! Click around for a bit on that site and you'll see what I mean about the tabs popping up and all that. Sometimes android 13 would give a popup after clicking around that says open with then it shows the google play store or the galaxy store.

matsushita1918 commented 1 year ago

Especially cosmetic.user.js filering for pop up blocking and idcac.user.js (I don't care about cookies), Probably, also for some redirects related to CNAME Trackers (Whether original or disguised)

#347 (comment)

how would you go about setting up that in this browser?

uazo commented 1 year ago

a river of words! let's go in order.

https://9anime.se/ there are many other free streaming sites that have this

Tried it, no popups bothering me. And at this point I'm asking, did you happen to turn off the flag under "Legacy adblock" setting?

it would be cool to have the option for the user to set a number of tabs that are allowed to open

I'm not going to do that.

matsushita1918 commented 1 year ago

https://animenosub.com/undead-unluck-episode-01/ on your phone to see the tab launching thing when you go to play the video, happens when you click play. And that option for legacy AdBlock is on

matsushita1918 commented 1 year ago

Sorry for the river of words dude lmao

matsushita1918 commented 1 year ago

The other thing too, tabs don't always launch, but sometimes they do and redirects do happen, it is a hit or miss at times, if there's no setting I can change then it's ok man, I looked in the flags settings in Chrome and all that.

uazo commented 1 year ago

https://github.com/uazo/cromite/issues/553#issuecomment-1830120769

perfect thank you that was exactly what I wanted. I'll let you know.

uazo commented 1 year ago

check ChromeContentBrowserClient::CanCreateWindow

matsushita1918 commented 12 months ago

This is in flags right? Don't see it in there or is there another way to access this?

uazo commented 12 months ago

If you're referring to my last comment, forget it, it's a note to me. I should find a way to automatically insert a comment after each first comment in all issues, so that I can leave it for my own thoughts. in bromite there was a bot, but I don't know what exactly it was and how to put it up.

uazo commented 10 months ago

I realised that adblockplus has pop-up blocking management but is not linked in the code. it must at least be connected.

uazo / cromite