Convert to pyproject.toml

ubarsc / tuiview

TuiView is a lightweight raster GIS with powerful raster attribute table manipulation abilities

http://tuiview.org/

GNU General Public License v2.0

26 stars 13 forks source link

Convert to pyproject.toml #88

Closed neilflood closed 1 month ago

neilflood commented 1 month ago

This is a draft first attempt, with some questions before merging. It all works, but may not be exactly what we want.

When does the check for GEOS support become important? I had to leave this out (see below)
When is cross compilation important? Was only checked during the GEOS check anyway, so probably not a big deal
The GDAL presence test now just relies on access to gdal-config, rather than access to the Python gdal module, because both pip and build want to work inside an isolated environment, which can't see an installed Python gdal module. This isolation can be disabled on either commandline, but that seems like pushing the problem onto the user.

No rush, just wanted to have an initial go at this.

gillins commented 1 month ago

Ah shame about the GEOS test, but that's the way it goes. Some of the tuiview functionality requires GDAL built with GEOS (can't remember what exactly) seems safe to assume it is, but someone did report a problem which was due to the fact they didn't have GEOS support. Perhaps I should have a check on tuiview startup instead? Cross compilation is used in conda for osx-arm64 and linux-arm64 (and for a while linux-ppc until problems where discovered in proj for this architecture). osx-arm64 is currently only available in cross compilation as actual hardware is rare and emulation isn't possible. For the linux cross targets there is a choice - have slow emulated builds or do cross compilation. I opted for cross compilation. There was actual hardware available for a while but that got pulled for some reason. Would be nice to be able to support it cross compilation...

neilflood commented 1 month ago

I can well imagine that Tuiview requires GEOS support, I just couldn't imagine circumstances in which it would not be there.

I don't think we have broken the cross compilation, it was just being checked as part of the GEOS check (i.e. don't try checking for GEOS if we are doing a cross compilation). So, if we are not checking for GEOS, we don't care. I think it should all still work, but just wanted to check with you.

gillins commented 1 month ago

Here is the PR: https://github.com/ubarsc/tuiview/pull/55, no mention of people having trouble - perhaps I imagined it. Yes let's assume that it is present and see what happens. We recommend conda builds anyway so people doing their own thing are on their own...