ubclaunchpad / Internado

🌪 Find Internship Opportunities
3 stars 1 forks source link

Refactored Clear Expired Jobs Script to Make HTTP Requests Asynchrono… #215

Open cormacjmollitor opened 5 years ago

cormacjmollitor commented 5 years ago

…usly

🔨 Changes

HTTP requests to job URL's are now asynchronous

:squirrel: Testing instructions

📄 Relevant screenshots or documentation links

:clipboard: Checklist

cowmanjoe commented 5 years ago

I'm getting occasional hanging and I'm not sure why. Maybe we should have a timeout on each individual HTTP request so that one HTTP request can't hang the whole thing.

Also, I think there may be a rate limit for hitting ZipRecruiter website jobs (jobs with link at ziprecruiter.com domain) because I got this notice when trying to access a job manually: this.

This was when I tried to do this multiple times on over 1000 jobs. One other thing that happened when it didn't hang though is that it deleted jobs on the second run that weren't deleted on the first run. Any ideas on why this would be happening? Sorry for the long comment that really only raised a bunch of hard questions :/