search

ubclaunchpad / bounce

🏀 Bringing people with common interests together
MIT License
3 stars 4 forks source link

Add support for storing images #69

Closed bfbachmann closed 6 years ago

bfbachmann commented 6 years ago

:tickets: Ticket(s): Closes #63

:construction_worker: Changes

:traffic_light: Concerns

Currently we don't point to these images with any extra columns in the users table. Perhaps we should. Not doing so makes the code simpler and it prevents situations where the information in the DB conflicts with the actual files in the IMAGE_DIR, so I think this is okay for now.

:mag: Testing Instructions

make test. You can also use Postman to upload, retrieve, and delete images.

bfbachmann commented 6 years ago

@stanleyye Good point, I totally forgot to check the image type. I just added image size (1MB max) and image type (JPEG/PNG) restrictions.