search

ubclaunchpad / bumper

🥊 Fast-paced multiplayer arcade game, built with Go, Javascript, and WebSockets
13 stars 2 forks source link

tommy/#236-pixiJS-init #259

Closed teelau closed 6 years ago

teelau commented 6 years ago

:tickets: Ticket(s): Closes #

:construction_worker: Changes

Init connection to server from new client based on pixiJS graphics library, no framework

:flashlight: Testing Instructions

Explain how to test your changes, if applicable. make server in the web directory containing index.html: python -m SimpleHTTPServer -8000 visit localhost:8000

teelau commented 6 years ago

it would be nice to have a local copy of pixiJS to keep version consistent, how to disable it from being built by travis, its minified.

brian-nguyen commented 6 years ago

it would be nice to have a local copy of pixiJS to keep version consistent

Hey Tommy, no need for this. The CDN allows us to lock the version. Thanks for bringing this up. I should lock down the bootstrap version.

Many of the Travis errors are coming from the pixi library, so we should either add the flag to ignore it or go with the CDN, which is better.

You can still fix the errors coming from your own JS files (except the indentation one, I gotta fix that :sweat_smile:)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 66.756% when pulling a01c52b3ac609bae8d24acc68d356f3b8d9e7bc4 on tommy/#236-init-pixiJS into 40f306cd30e9c9f9b676d0ce21b07489ce4e08db on master.