Closed madneal closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.60%. Comparing base (
56f5ac5
) to head (ae7824b
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sonalmahajan15 seems some issue with the golden test
@madneal , yes, something seems to be wrong. We'll look into it and merge the PR.
Yeah, I think we'll have to wait for https://github.com/golang/go/issues/61324 to have an importable checker API to use.
I'm updating your branch since we recently fixed the CI issue, and we'll need those changes in order for CI to pass :)
[!NOTE]
✅ NilAway errors reported on standard libraries are identical.3271 errors on base branch (main, 56f5ac5) 3271 errors on test branch (a747e8e)
Thanks @madneal for the contributions!
This PR provides a tip when output as JSON due to the current default
pretty-print
flagCurrent Issue
For the orginal json flag provided by checker.go, it's impossible to get
analysisflags.JSON
from nilaway. There is a conflict bettwen thepretty-print
andjson
output currently due to the code https://github.com/uber-go/nilaway/blob/e90288479601315af13b7fdd3ccd6b50c53a8e7c/nilaway.go#L43. As the defaultconf.PrettyPrint
is true, so the output will be messy when try to output as json.