codecov[bot]
commented
5 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.70%. Comparing base (
8a805fa) to head (4ec8a00).:exclamation: Current head 4ec8a00 differs from pull request most recent head 76bcd09
Please upload reports for the commit 76bcd09 to get more accurate results.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1444 +/- ## ======================================= Coverage 98.70% 98.70% ======================================= Files 53 53 Lines 3014 3014 ======================================= Hits 2975 2975 Misses 31 31 Partials 8 8 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
unmarshalText currently checks for almost all of the levels as the configured string values as well as their capitalized versions.
But we call unmarshalText with bytes.ToLower() when we actually parse the levels, so we do not need to check for the capitalized versions separately since this is redundant.
Previous version of this PR was trying to add "WARNING" as a check to this since that was recently added but the corresponding capitalized string wasn't checked, but @abhinav pointed out that we actually call this with ToLower, so it's better to remove the redundant checks.