uber / cyborg

Display Android Vectordrawables on iOS.
Apache License 2.0
302 stars 19 forks source link

Theme changes are not propogated in VectorView #31

Closed benpious closed 5 years ago

benpious commented 6 years ago

Exactly as the title. The theme that the view is initialized with is used regardless of whether VectorView.externalValues is set.

benpious commented 5 years ago

Not sure when this was resolved, but it was, possibly as a consequence of some architectural changes. The new problem is that theme propagation is probably not very performant, which will be addressed later.