uber / neuropod

A uniform interface to run deep learning models from multiple frameworks
https://neuropod.ai
Apache License 2.0
936 stars 77 forks source link

Remove _always_use_native=False #526

Closed VivekPanyam closed 2 years ago

VivekPanyam commented 2 years ago

Summary:

_always_use_native=False was always intended to be a workaround (hence the leading _) and has had a deprecation warning since #508.

Removing this functionality allows us to delete a lot of code and have a single inference code path across C, C++, Java, Python, and Go.

Test Plan:

CI

VivekPanyam commented 2 years ago

cc @csashiuber @qiyanz @vkuzmin-uber

codecov[bot] commented 2 years ago

Codecov Report

Merging #526 (8919b7b) into master (a47d1c8) will decrease coverage by 0.64%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   87.21%   86.56%   -0.65%     
==========================================
  Files         111      105       -6     
  Lines        7289     6930     -359     
==========================================
- Hits         6357     5999     -358     
+ Misses        932      931       -1     
Impacted Files Coverage Δ
source/python/neuropod/loader.py 65.15% <ø> (-29.92%) :arrow_down:
source/python/neuropod/utils/eval_utils.py 78.37% <100.00%> (-3.02%) :arrow_down:
source/python/neuropod/utils/config_utils.py 88.46% <0.00%> (-6.42%) :arrow_down:
source/python/neuropod/utils/env_utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a47d1c8...8919b7b. Read the comment docs.