uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.78k stars 285 forks source link

Remove duplicate reader type tested in test_end_to_end.py #509

Closed selitvin closed 4 years ago

selitvin commented 4 years ago

No point in running tests twice using the same flavor of reader.

codecov[bot] commented 4 years ago

Codecov Report

Merging #509 into master will decrease coverage by 0.32%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   86.09%   85.77%   -0.33%     
==========================================
  Files          81       81              
  Lines        4358     4358              
  Branches      694      694              
==========================================
- Hits         3752     3738      -14     
- Misses        500      509       +9     
- Partials      106      111       +5     
Impacted Files Coverage Δ
petastorm/test_util/reader_mock.py 82.85% <0.00%> (-2.86%) :arrow_down:
petastorm/weighted_sampling_reader.py 85.00% <0.00%> (-2.50%) :arrow_down:
petastorm/pytorch.py 87.80% <0.00%> (-2.44%) :arrow_down:
petastorm/unischema.py 92.61% <0.00%> (-1.98%) :arrow_down:
petastorm/workers_pool/process_pool.py 92.70% <0.00%> (-1.05%) :arrow_down:
petastorm/workers_pool/thread_pool.py 88.42% <0.00%> (-0.83%) :arrow_down:
petastorm/hdfs/tests/test_hdfs_namenode.py 98.96% <0.00%> (-0.70%) :arrow_down:
petastorm/reader.py 90.52% <0.00%> (-0.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f51196...ed3ae51. Read the comment docs.