search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.78k stars 285 forks source link

Replace deprecated Schema.add_metadata with Schema.with_metadata call. #528

Closed selitvin closed 4 years ago

selitvin commented 4 years ago

No functionality change as we can see from:

    def add_metadata(self, metadata):
        warnings.warn("The 'add_metadata' method is deprecated, use "
                      "'with_metadata' instead", FutureWarning, stacklevel=2)
        return self.with_metadata(metadata)

Our CI does not test all pyarrow versions (just 0.12.1 and 0.15.1), so tried locally 0.13, 0.14 and 0.15)

codecov[bot] commented 4 years ago

Codecov Report

Merging #528 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   86.50%   86.52%   +0.02%     
==========================================
  Files          85       85              
  Lines        4705     4713       +8     
  Branches      741      743       +2     
==========================================
+ Hits         4070     4078       +8     
  Misses        516      516              
  Partials      119      119
Impacted Files Coverage Δ
petastorm/compat.py 100.00% <100.00%> (ø)
petastorm/unischema.py 95.79% <100.00%> (ø)
petastorm/utils.py 91.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2012858...9c1d65f. Read the comment docs.