search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.78k stars 285 forks source link

Add imports to README example. #567

Closed rb-determined-ai closed 4 years ago

rb-determined-ai commented 4 years ago

I found that the fully-functional hello world example code was great for approaching the project for the first time... but figuring out these imports was pretty time consuming, and I thought it might be nice to just embed them in the example.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #567 into master will decrease coverage by 0.50%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   85.67%   85.16%   -0.51%     
==========================================
  Files          87       87              
  Lines        4976     4976              
  Branches      794      794              
==========================================
- Hits         4263     4238      -25     
- Misses        577      591      +14     
- Partials      136      147      +11
Impacted Files Coverage Δ
petastorm/compat.py 60.97% <0.00%> (-39.03%) :arrow_down:
petastorm/tf_utils.py 85.10% <0.00%> (-3.55%) :arrow_down:
petastorm/arrow_reader_worker.py 90.00% <0.00%> (-2.00%) :arrow_down:
petastorm/py_dict_reader_worker.py 94.44% <0.00%> (-0.80%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a121f32...95c7654. Read the comment docs.

rb-determined-ai commented 4 years ago

@jsgoller1 cool! I signed the CLA. FWIW I am always in favor of copy/paste examples over Jupyter notebooks.

Also, I added another couple missing imports I found.