search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.78k stars 285 forks source link

Parameterize factory methods with s3 configs #594

Closed dmcguire81 closed 4 years ago

dmcguire81 commented 4 years ago

Implements #593

codecov[bot] commented 4 years ago

Codecov Report

Merging #594 into master will not change coverage. The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          87       87           
  Lines        4994     4994           
  Branches      795      795           
=======================================
  Hits         4279     4279           
  Misses        578      578           
  Partials      137      137
Impacted Files Coverage Δ
petastorm/fs_utils.py 91.75% <75.00%> (ø)
petastorm/reader.py 90.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da48ec8...af3edd3. Read the comment docs.

dmcguire81 commented 4 years ago

Updated. This can be merged.

dmcguire81 commented 4 years ago

@selitvin how do I make the erroneous Codecov errors go away?

selitvin commented 4 years ago

I think it's about codecov configuration file. Did not have time to fix this - I am just looking at the actual numbers and if they make sense, then force land it.