Improve cache by not storing ORIG_HEAD

uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications

http://www.uber.com

MIT License

835 stars 83 forks source link

Improve cache by not storing ORIG_HEAD #158

Closed motiejus closed 8 years ago

motiejus commented 8 years ago

glide install step touches ORIG_HEAD of some dependencies, causing it to update the whole cache on every run. If we remove it, the cache will not need to be updated after every execution, speeding all tests.

Tests here:

https://travis-ci.org/uber/ringpop-go/jobs/141601533 (initial run, filling cache)
https://travis-ci.org/uber/ringpop-go/jobs/141608840 (subsequent run)

At the end of the second run, observe "store build cache.. nothing changed, not updating cache".

coveralls commented 8 years ago

Coverage decreased (-0.05%) to 94.621% when pulling e02628ae3390c6c5c12928540e3ccb066839d6b2 on motiejus-fix-cache into 6a7722079e2c3c605e94a75bd628ea87b2d9115e on dev.

coveralls commented 8 years ago

Coverage increased (+0.07%) to 94.738% when pulling e02628ae3390c6c5c12928540e3ccb066839d6b2 on motiejus-fix-cache into 6a7722079e2c3c605e94a75bd628ea87b2d9115e on dev.

dansimau commented 8 years ago

LGTM

thanodnl commented 8 years ago

LGTM