Use narrower duck-typing instead of embedding whole interface

uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications

http://www.uber.com

MIT License

835 stars 83 forks source link

Use narrower duck-typing instead of embedding whole interface #165

Closed yurishkuro closed 8 years ago

yurishkuro commented 8 years ago

The tchannel.Registrar interface has been extended with an extra method, and there are compile errors in our internal go-common library against ringpop-go/0.6.0

ringpop does not need the whole tchannel.Registrar interface in its duck-typed TChannel interface, just the Register() method.

coveralls commented 8 years ago

Coverage remained the same at 94.621% when pulling 7428f40971815ddf99b1ae79d244e19c230b2502 on narrow-tchannel-expectations into 6a071f771d16065ab04c42b4ecf2a05d3e5ce767 on master.

coveralls commented 8 years ago

Coverage increased (+0.09%) to 94.715% when pulling f7a3f5fb4235514bd81f6ef0b103f5e614f39d50 on narrow-tchannel-expectations into 6a071f771d16065ab04c42b4ecf2a05d3e5ce767 on master.

dansimau commented 8 years ago

LGTM 👍

yurishkuro commented 8 years ago

Should this merge to master or to dev?

mennopruijssers commented 8 years ago

Should this merge to master or to dev?

Dev. However, the default branch on github is master because go get, glide and other tooling is using github's default branch. Sorry for the inconvenience.