Use narrower duck-typing instead of embedding whole interface

uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications

http://www.uber.com

MIT License

835 stars 83 forks source link

Use narrower duck-typing instead of embedding whole interface #166

Closed yurishkuro closed 8 years ago

yurishkuro commented 8 years ago

Recreating #165 to merge to dev instead of master

The tchannel.Registrar interface has been extended with an extra method, and there are compile errors in our internal go-common library against ringpop-go/0.6.0

ringpop does not need the whole tchannel.Registrar interface in its duck-typed TChannel interface, just the Register() method.

dansimau commented 8 years ago

LGTM 👍

coveralls commented 8 years ago

Coverage remained the same at 94.761% when pulling f7a3f5fb4235514bd81f6ef0b103f5e614f39d50 on narrow-tchannel-expectations into 027b554f7d16399ad51e09133ac2675caf9e16cf on dev.