search

uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications
http://www.uber.com
MIT License
835 stars 83 forks source link

Correct ineffassign warnings #193

Closed gliptak closed 7 years ago

gliptak commented 7 years ago

https://goreportcard.com/report/github.com/uber/ringpop-go

gliptak commented 7 years ago

https://travis-ci.org/uber/ringpop-go/jobs/181822850 Go 1.5 fails with:

# golang.org/x/tools/go/gcimporter15

../../../golang.org/x/tools/go/gcimporter15/bexport.go:557: undefined: constant.ToFloat

../../../golang.org/x/tools/go/gcimporter15/gcimporter.go:396: pkg.SetName undefined (type *types.Package has no field or method SetName)

make: *** [dev_deps] Error 2
mennopruijssers commented 7 years ago

We removed go 1.5. Please rebase on the dev branch and edit your PR to change the base to dev.

mennopruijssers commented 7 years ago

But thanks for looking into this! Would be awesome if you could sign our CLA: https://cla-assistant.io/uber/ringpop-go?pullRequest=193.

Thanks!

gliptak commented 7 years ago

@mennopruijssers I signed the CLA and rebased PR