search

uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications
http://www.uber.com
MIT License
835 stars 83 forks source link

Add WithError() to NoLogger #203

Closed andrewdeandrade closed 7 years ago

andrewdeandrade commented 7 years ago

The Bark logger interface now has a WithError(err Error) bark.Logger method. Just adding that to the NoLogger interface.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

eculver commented 7 years ago

I just bumped into this too, would be nice to get it merged sooner rather than later.

rtfb commented 7 years ago

Can somebody in the know confirm that the tests are failing for unrelated reasons?

mennopruijssers commented 7 years ago

The errors are caused by tcurl outputting a line to upgrade to yab. This should be fixed by pinning tcurl to version v4.22.2

mennopruijssers commented 7 years ago

@malandrew It would be awesome if you could sign our CLA . After you've signed it, I'll merge and release a new version of ringpop.

andrewdeandrade commented 7 years ago

@mennopruijssers Just got back from vacation. Signed the CLA. FWIW, it wasn't actually necessary for me to sign the CLA since I'm also an Uber employee.

albertyfwu commented 7 years ago

I just created a pull request as well. Bumping this in hopes it will be landed soon.