ubiquity-os-marketplace / command-wallet

Commands related to wallet update and query.
0 stars 5 forks source link

Change logs to use `ubiquity-dao/ubiquibot-logger` #4

Open gentlementlegen opened 2 months ago

gentlementlegen commented 2 months ago

Currently the logs are handled manually with console messages. They should use our logger package to follow our usual display standards and logic.

https://github.com/ubiquity/ubiquibot-logger

C.f. https://github.com/ubiquibot/command-wallet/pull/2#discussion_r1668052899 and https://github.com/ubiquibot/command-wallet/pull/2#discussion_r1668051345

wolfmic commented 1 month ago

/wallet 0xFaF2BD96905b7DAf432534FF4Fa75D90A36614eE

ubiquityos[bot] commented 1 month ago

+ Successfully registered wallet address
ubiquibot[bot] commented 1 month ago
+ Successfully registered wallet address
wolfmic commented 1 month ago

/start

ubiquityos[bot] commented 1 month ago
DeadlineSun, Aug 18, 3:58 PM UTC
Registered Wallet 0xFaF2BD96905b7DAf432534FF4Fa75D90A36614eE
Tips:
<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>
ubiquibot[bot] commented 1 month ago

Warning! This task was created over 41 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineSun, Aug 18, 3:58 PM UTC
Registered Wallet 0xFaF2BD96905b7DAf432534FF4Fa75D90A36614eE
Tips:
wolfmic commented 1 month ago

Since there is context.logger.warn() in two files (plugin.ts and command-parser.ts), should it be replaced with info method or should I wait until warn is getting implemented?

gentlementlegen commented 1 month ago

@wolfmic I think using logger.error instead of warn is fine for now.