search

ubiquity-os-marketplace / disqualifier

Follows up on user activities related to task, sends reminders, and unassign inactive users.
0 stars 9 forks source link

Improve tests #14

Closed Keyrxng closed 2 weeks ago

Keyrxng commented 1 month ago

They would benefit from being brought inline with other plugin test suites covering more of the logic and paths

Time - 2 hours

ubiquibot[bot] commented 1 month ago 
! action has an uncaught error
ubiquity-os[bot] commented 4 weeks ago

[ 56.6 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 50
Issue Specification 1 6.6
Review Comment 18 0
Conversation Incentives
Comment Formatting Relevance Reward
They would benefit from being brought inline with other plugin t…
6.6 
content:
  p:
    symbols:
      \b\w+\b:
        count: 22
        multiplier: 0.1
    score: 1
multiplier: 3
1 6.6
Resolves #14 Requires #13
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0
    score: 1
multiplier: 0
0.3 -
My mistake I'll remove that, I use `npx tsx t.ts` to run…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 16
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I wouldn't as it drastically increases the chance we get rate li…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 79
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.2
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I understand where you are coming from with this but the reason …
0 
content:
  h2:
    symbols:
      \b\w+\b:
        count: 85
        multiplier: 0.2
    score: 1
  p:
    symbols:
      \b\w+\b:
        count: 39
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I think we should keep this and standardize it. There is no down…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 27
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I assumed it wouldn't but it works with `.ts`
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 10
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Yeah Jest fails to import it. My format-on-save was forcing the …
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 18
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Which default value do you mean sorry? `optOut`? This wa…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 18
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I'll need to take the function from `command-start-stop`…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 23
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Yeah I guess it is now that you point it out lmao
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 12
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I'm not sure whether [this](https://github.com/ubiquibot/user-ac…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 40
        multiplier: 0.2
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
The search endpoint seems to be doing the damage, I only have my…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 27
        multiplier: 0.2
    score: 1
  ul:
    symbols:
      \b\w+\b:
        count: 50
        multiplier: 0.2
    score: 1
  li:
    symbols:
      \b\w+\b:
        count: 48
        multiplier: 0.2
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I will tidy the code up and find any final optimizations or chan…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 58
        multiplier: 0.2
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
@gentlementlegen What would you suggest? I am relying on the m…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 72
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I had just written logic (haven't pushed) to strip the HTML comm…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 34
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
I'll refactor and use the GraphQL API then no worries
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 11
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Will do thanks
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
@gentlementlegen the difficult part was figuring out you could m…
0 
content:
  p:
    symbols:
      \b\w+\b:
        count: 79
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.2
    score: 1
multiplier: 0
1 -

[ 42.5 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 16 42.5
Conversation Incentives
Comment Formatting Relevance Reward
Testing on my org and seems to work properly: https://github.com…
2.4 
content:
  p:
    symbols:
      \b\w+\b:
        count: 24
        multiplier: 0.1
    score: 1
multiplier: 1
1 2.4
What is this file?
0.4 
content:
  p:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.4
Small optimization but this could all be done in parallel throug…
1.9 
content:
  p:
    symbols:
      \b\w+\b:
        count: 17
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.9
Yeah makes sense, let's keep it that way then.
1 
content:
  p:
    symbols:
      \b\w+\b:
        count: 10
        multiplier: 0.1
    score: 1
multiplier: 1
1 1
I guess this doesn't work as a TypeScript file? Couldn't find an…
1.7 
content:
  p:
    symbols:
      \b\w+\b:
        count: 17
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.7
```suggestion ```
0.1 
content:
  pre:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.1
```suggestion const query = /* GraphQl */ `quer…
1.1 
content:
  pre:
    symbols:
      \b\w+\b:
        count: 11
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 11
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.1
Is this just to mock the module? Doesn't seem properly indented.
1.2 
content:
  p:
    symbols:
      \b\w+\b:
        count: 12
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.2
Maybe this default value should be changed to something meaningf…
1 
content:
  p:
    symbols:
      \b\w+\b:
        count: 10
        multiplier: 0.1
    score: 1
multiplier: 1
1 1
I just understood that it is testing weird values on purpose, di…
2.1 
content:
  p:
    symbols:
      \b\w+\b:
        count: 21
        multiplier: 0.1
    score: 1
multiplier: 1
1 2.1
@Keyrxng I tested the search query you use, and I think it is no…
13.4 
content:
  h2:
    symbols:
      \b\w+\b:
        count: 94
        multiplier: 0.1
    score: 1
  p:
    symbols:
      \b\w+\b:
        count: 21
        multiplier: 0.1
    score: 1
  pre:
    symbols:
      \b\w+\b:
        count: 19
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 19
        multiplier: 0.1
    score: 1
multiplier: 1
1 13.4
@Keyrxng I think this would be way more reliable than manually p…
5.6 
content:
  p:
    symbols:
      \b\w+\b:
        count: 55
        multiplier: 0.1
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 1
1 5.6
Let me know if you encounter major issues. We have another repos…
3.5 
content:
  p:
    symbols:
      \b\w+\b:
        count: 35
        multiplier: 0.1
    score: 1
multiplier: 1
1 3.5
It would be nice to have Graphql config, similar to the one ment…
1.5 
content:
  p:
    symbols:
      \b\w+\b:
        count: 14
        multiplier: 0.1
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.5
Interesting that the bot didn't care about your comments @0x4007…
3.6 
content:
  p:
    symbols:
      \b\w+\b:
        count: 33
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.1
    score: 1
multiplier: 1
1 3.6
It is using lots of new features we never tried before. Nothing …
2 
content:
  p:
    symbols:
      \b\w+\b:
        count: 18
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.1
    score: 1
multiplier: 1
1 2

[ 1.175 WXDAI ]

@whilefoo
Contributions Overview
View Contribution Count Reward
Review Comment 4 1.175
Conversation Incentives
Comment Formatting Relevance Reward
I'd try to avoid making tests relying on the logger since that c…
0.825 
content:
  p:
    symbols:
      \b\w+\b:
        count: 33
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.825
isn't this just `.filter()`?
0.15 
content:
  p:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.15
```suggestion export async function getTaskMetadata…
0.1 
content:
  pre:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.1
```suggestion export async function getDeadlineWith…
0.1 
content:
  pre:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.1

[ 10 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Review Comment 9 10
Conversation Incentives
Comment Formatting Relevance Reward
```suggestion ```
0.1 
content:
  pre:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.1
```suggestion run(program).then((result) => core…
0.8 
content:
  pre:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.8
Then its fine I guess but seems unnecessary because my yarn neve…
1.4 
content:
  p:
    symbols:
      \b\w+\b:
        count: 14
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.4
Match with metadata header instead
0.5 
content:
  p:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.5
Perhaps you can use the real metadata parser, the original one I…
1.3 
content:
  p:
    symbols:
      \b\w+\b:
        count: 13
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.3
How is this pull coming along?
0.6 
content:
  p:
    symbols:
      \b\w+\b:
        count: 6
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.6
When do you think we can start using this plugin?
1 
content:
  p:
    symbols:
      \b\w+\b:
        count: 10
        multiplier: 0.1
    score: 1
multiplier: 1
1 1
Great to see this Sure it can be handled in a separate task if i…
3.5 
content:
  p:
    symbols:
      \b\w+\b:
        count: 35
        multiplier: 0.1
    score: 1
multiplier: 1
1 3.5
I don't understand why reliability is decreasing
0.8 
content:
  p:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.8
rndquu commented 4 weeks ago

/help

ubiquity-os[bot] commented 4 weeks ago

Available Commands

Command Description Example
/help List all available commands. /help
/allow Allows the user to modify the given label. /allow @user1 label
/query Returns the user's wallet, access, and multiplier information. /query @ubiquibot
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/wallet Register your wallet address for payments. /wallet ubq.eth
rndquu commented 4 weeks ago

/query @gentlementlegen

ubiquity-os[bot] commented 4 weeks ago
Property Value
Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED