search

ubiquity-os-marketplace / disqualifier

Follows up on user activities related to task, sends reminders, and unassign inactive users.
0 stars 9 forks source link

feat: linked pull request activity is now taken into account #8

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 2 months ago

Resolves #6

rndquu commented 2 months ago

@gentlementlegen What is the difference between connected and cross-referenced issue events?

When PR body is updated with Resolves #1 then the connected issue event is created. When issue is mentioned in the issue or PR comments then cross-referenced event is created. Correct?

If so then why do we need to track cross-referenced issue type here? Can't we simply check only for the connected type?

gentlementlegen commented 2 months ago

@rndquu From my understanding, connected events can only be created through the Github UI (this website) when you click on the gear next to Development and manually add a pull-request. cross-referenced happens either when you write Resolves #1 in the body of the PR, or when you write a comment saying See also #1, if I remember correctly.

However, according to the docs, connected event should be the one defining that a pull-request is supposed to close the linked issue, so theoretically you are right: https://docs.github.com/en/rest/using-the-rest-api/issue-event-types?apiVersion=2022-11-28#connected To be double checked but I don't think that's what actually happens.